fix(post-gen-hook): populate project.yml with more accurate details#26
Merged
Conversation
![ai-coding-guardrails[bot]](https://avatars.githubusercontent.com/in/1202546?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've got 2 comments for you to consider
The PR title and description are not accurate. Here are my suggestions:
Title: refactor(post-gen-hook): improve template handling and fix project.yml generation
Description: # Contributor Comments
This PR refactors the post-generation hook with several improvements:
Key Changes
- Template handling: Added distinction between remote and local templates for better context resolution
- Performance: Implemented lazy loading for git imports
- Code quality: Removed pylint disable comments and improved code structure
- Project metadata: Fixed generated
.github/project.ymlto populate correct details about repo generation
Project.yml Improvements
The generated project metadata now includes proper template information with fully qualified paths instead of local development paths.
Previously the generated file contained local paths like:
_template: /Users/jonzeolla/src/zenable/testing
location: /Users/jonzeolla/src/zenable/testingNow it properly reflects the actual template source and generation context.
Pull Request Checklist
- If you are adding a dependency, please explain how it was chosen.
- If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
- Validate that documentation is accurate and aligned to any project updates or additions.
Reviewed with 🤟 by Zenable
JonZeolla
commented
Jul 9, 2025
JonZeolla
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This fixes the generated
.github/project.ymlto have correct details about the generation of a repo.Now it looks like this:
Previously it looked like this in my local testing:
Pull Request Checklist
Thank you for submitting a contribution!
Please address the following items: